Commit ae325dcd authored Mar 17, 2019 by Nikos Tsironis Committed by Mike Snitzer Apr 18, 2019

list: Don't use WRITE_ONCE() in hlist_add_behind()



Commit 1c97be67 ("list: Use WRITE_ONCE() when adding to lists and
hlists") introduced the use of WRITE_ONCE() to atomically write the list
head's ->next pointer.

hlist_add_behind() doesn't touch the hlist head's ->first pointer so
there is no reason to use WRITE_ONCE() in this case.

Co-developed-by: Ilias Tsitsimpis <iliastsi@arrikto.com>
Signed-off-by: Nikos Tsironis <ntsironis@arrikto.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent e28adc3b

include/linux/list.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -754,7 +754,7 @@ static inline void hlist_add_behind(struct hlist_node *n,
		struct hlist_node *prev)
		{
		n->next = prev->next;
		WRITE_ONCE(prev->next, n);
		prev->next = n;
		n->pprev = &prev->next;

		if (n->next)