Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adecda5b authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by David S. Miller
Browse files

net: print proper warning on dst underflow 



Proper warnings with stack traces make it much easier to figure out
what's doing the double free and create more meaningful bug reports from
users.

Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3e8b9bfa

net/core/dst.c

+2 −2
Original line number Diff line number Diff line
@@ -172,7 +172,7 @@ void dst_release(struct dst_entry *dst) 
		int newrefcnt;



		newrefcnt = atomic_dec_return(&dst->__refcnt);

		if (unlikely(newrefcnt < 0))

		if (WARN_ONCE(newrefcnt < 0, "dst_release underflow"))

			net_warn_ratelimited("%s: dst:%p refcnt:%d\n",

					     __func__, dst, newrefcnt);

		if (!newrefcnt)
@@ -187,7 +187,7 @@ void dst_release_immediate(struct dst_entry *dst) 
		int newrefcnt;



		newrefcnt = atomic_dec_return(&dst->__refcnt);

		if (unlikely(newrefcnt < 0))

		if (WARN_ONCE(newrefcnt < 0, "dst_release_immediate underflow"))

			net_warn_ratelimited("%s: dst:%p refcnt:%d\n",

					     __func__, dst, newrefcnt);

		if (!newrefcnt)