Commit adeb24af authored Aug 23, 2022 by Kuniyuki Iwashima Committed by Greg Kroah-Hartman Sep 05, 2022

net: Fix a data-race around netdev_budget.



[ Upstream commit 2e0c42374ee32e72948559d2ae2f7ba3dc6b977c ]

While reading netdev_budget, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 51b0bded ("[NET]: Separate two usages of netdev_max_backlog.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 575c57e9

net/core/dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6394,7 +6394,7 @@ static __latent_entropy void net_rx_action(struct softirq_action *h)
		struct softnet_data *sd = this_cpu_ptr(&softnet_data);
		unsigned long time_limit = jiffies +
		usecs_to_jiffies(netdev_budget_usecs);
		int budget = netdev_budget;
		int budget = READ_ONCE(netdev_budget);
		LIST_HEAD(list);
		LIST_HEAD(repoll);