Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit addb3ffb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Marcel Holtmann
Browse files

Bluetooth: mediatek: Fix memory leak 



In case memory resources for *fw* were allocated, release them before
return.

Addresses-Coverity-ID: 1472611 ("Resource leak")
Fixes: 7237c4c9 ("Bluetooth: mediatek: Add protocol support for MediaTek serial devices")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarSean Wang <sean.wang@mediatek.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 51474eff

drivers/bluetooth/btmtkuart.c

+5 −3
Original line number Diff line number Diff line
@@ -144,8 +144,10 @@ static int mtk_setup_fw(struct hci_dev *hdev) 
	fw_size = fw->size;



	/* The size of patch header is 30 bytes, should be skip */

	if (fw_size < 30)

		return -EINVAL;

	if (fw_size < 30) {

		err = -EINVAL;

		goto free_fw;

	}



	fw_size -= 30;

	fw_ptr += 30;
@@ -172,8 +174,8 @@ static int mtk_setup_fw(struct hci_dev *hdev) 
		fw_ptr += dlen;

	}



free_fw:

	release_firmware(fw);



	return err;

}