Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adcb0ca2 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Darrick J. Wong
Browse files

xfs: fix the dax supported check in xfs_ioctl_setattr_dax_invalidate 



Setting the DAX flag on the directory of a file system that is not on a
DAX capable device makes as little sense as setting it on a regular file
on the same file system.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 40144e49

fs/xfs/xfs_ioctl.c

+1 −2
Original line number Diff line number Diff line
@@ -1309,8 +1309,7 @@ xfs_ioctl_setattr_dax_invalidate( 
	if (fa->fsx_xflags & FS_XFLAG_DAX) {

		if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))

			return -EINVAL;

		if (S_ISREG(inode->i_mode) &&

		    !bdev_dax_supported(xfs_find_bdev_for_inode(VFS_I(ip)),

		if (!bdev_dax_supported(xfs_find_bdev_for_inode(VFS_I(ip)),

				sb->s_blocksize))

			return -EINVAL;

	}