Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acb1ce15 authored by Yonglong Liu's avatar Yonglong Liu Committed by David S. Miller
Browse files

net: hns: Use NAPI_POLL_WEIGHT for hns driver 



When the HNS driver loaded, always have an error print:
"netif_napi_add() called with weight 256"

This is because the kernel checks the NAPI polling weights
requested by drivers and it prints an error message if a driver
requests a weight bigger than 64.

So use NAPI_POLL_WEIGHT to fix it.

Signed-off-by: default avatarYonglong Liu <liuyonglong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3a39a12a

drivers/net/ethernet/hisilicon/hns/hns_enet.c

+2 −5
Original line number Diff line number Diff line
@@ -29,9 +29,6 @@ 


#define SERVICE_TIMER_HZ (1 * HZ)



#define NIC_TX_CLEAN_MAX_NUM 256

#define NIC_RX_CLEAN_MAX_NUM 64



#define RCB_IRQ_NOT_INITED 0

#define RCB_IRQ_INITED 1

#define HNS_BUFFER_SIZE_2048 2048
@@ -2153,7 +2150,7 @@ static int hns_nic_init_ring_data(struct hns_nic_priv *priv) 
			hns_nic_tx_fini_pro_v2;



		netif_napi_add(priv->netdev, &rd->napi,

			       hns_nic_common_poll, NIC_TX_CLEAN_MAX_NUM);

			       hns_nic_common_poll, NAPI_POLL_WEIGHT);

		rd->ring->irq_init_flag = RCB_IRQ_NOT_INITED;

	}

	for (i = h->q_num; i < h->q_num * 2; i++) {
@@ -2166,7 +2163,7 @@ static int hns_nic_init_ring_data(struct hns_nic_priv *priv) 
			hns_nic_rx_fini_pro_v2;



		netif_napi_add(priv->netdev, &rd->napi,

			       hns_nic_common_poll, NIC_RX_CLEAN_MAX_NUM);

			       hns_nic_common_poll, NAPI_POLL_WEIGHT);

		rd->ring->irq_init_flag = RCB_IRQ_NOT_INITED;

	}