Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac59a471 authored by Petr Mladek's avatar Petr Mladek
Browse files

livepatch: Remove duplicate warning about missing reliable stacktrace support 



WARN_ON_ONCE() could not be called safely under rq lock because
of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in
klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return
-ENOSYS thanks to klp_have_reliable_stack() check in
klp_try_switch_task().

[ mbenes: changelog edited ]
Signed-off-by: default avatarMiroslav Benes <mbenes@suse.cz>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: default avatarKamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 67059d65

kernel/livepatch/transition.c

+0 −1
Original line number Diff line number Diff line
@@ -259,7 +259,6 @@ static int klp_check_stack(struct task_struct *task, char *err_buf) 
	int ret, nr_entries;



	ret = stack_trace_save_tsk_reliable(task, entries, ARRAY_SIZE(entries));

	WARN_ON_ONCE(ret == -ENOSYS);

	if (ret < 0) {

		snprintf(err_buf, STACK_ERR_BUF_SIZE,

			 "%s: %s:%d has an unreliable stack\n",