Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac4bf4a1 authored by Colin Ian King's avatar Colin Ian King Committed by Alex Deucher
Browse files

drm/amdgpu: fix unsigned variable instance compared to less than zero 



Currenly the error check on variable instance is always false because
it is a uint32_t type and this is never less than zero. Fix this by
making it an int type.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 7d0e6329 ("drm/amdgpu: update more sdma instances irq support")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f0ced3f6

drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

+2 −1
Original line number Diff line number Diff line
@@ -1963,7 +1963,8 @@ static int sdma_v4_0_process_ras_data_cb(struct amdgpu_device *adev, 
		struct ras_err_data *err_data,

		struct amdgpu_iv_entry *entry)

{

	uint32_t instance, err_source;

	uint32_t err_source;

	int instance;



	instance = sdma_v4_0_irq_id_to_seq(entry->client_id);

	if (instance < 0)