Commit ac498323 authored Jul 26, 2021 by Maor Gottlieb Committed by Greg Kroah-Hartman Aug 04, 2021

net/mlx5: Fix flow table chaining



[ Upstream commit 8b54874ef1617185048029a3083d510569e93751 ]

Fix a bug when flow table is created in priority that already
has other flow tables as shown in the below diagram.
If the new flow table (FT-B) has the lowest level in the priority,
we need to connect the flow tables from the previous priority (p0)
to this new table. In addition when this flow table is destroyed
(FT-B), we need to connect the flow tables from the previous
priority (p0) to the next level flow table (FT-C) in the same
priority of the destroyed table (if exists).

                       ---------
                       |root_ns|
                       ---------
                            |
            --------------------------------
            |               |              |
       ----------      ----------      ---------
       |p(prio)-x|     |   p-y  |      |   p-n |
       ----------      ----------      ---------
            |               |
     ----------------  ------------------
     |ns(e.g bypass)|  |ns(e.g. kernel) |
     ----------------  ------------------
            |            |           |
	-------	       ------       ----
        |  p0 |        | p1 |       |p2|
        -------        ------       ----
           |             |    \
        --------       ------- ------
        | FT-A |       |FT-B | |FT-C|
        --------       ------- ------

Fixes: f90edfd2 ("net/mlx5_core: Connect flow tables")
Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 527feae5

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -968,17 +968,19 @@ static int connect_fwd_rules(struct mlx5_core_dev *dev,
		static int connect_flow_table(struct mlx5_core_dev dev, struct mlx5_flow_table ft,
		struct fs_prio *prio)
		{
		struct mlx5_flow_table *next_ft;
		struct mlx5_flow_table next_ft, first_ft;
		int err = 0;

		/* Connect_prev_fts and update_root_ft_create are mutually exclusive */

		if (list_empty(&prio->node.children)) {
		first_ft = list_first_entry_or_null(&prio->node.children,
		struct mlx5_flow_table, node.list);
		if (!first_ft \|\| first_ft->level > ft->level) {
		err = connect_prev_fts(dev, ft, prio);
		if (err)
		return err;

		next_ft = find_next_chained_ft(prio);
		next_ft = first_ft ? first_ft : find_next_chained_ft(prio);
		err = connect_fwd_rules(dev, ft, next_ft);
		if (err)
		return err;
		@@ -2026,7 +2028,7 @@ static int disconnect_flow_table(struct mlx5_flow_table *ft)
		node.list) == ft))
		return 0;

		next_ft = find_next_chained_ft(prio);
		next_ft = find_next_ft(ft);
		err = connect_fwd_rules(dev, next_ft, ft);
		if (err)
		return err;