Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac2f2a77 authored by Naman Padhiar's avatar Naman Padhiar Committed by Gerrit - the friendly Code Review server
Browse files

icnss2: Use event_data before posting event 



As part of posted event, event_data is getting freed.
Check for FW crashed using event_data after posting
event can be incorrect since event_data might have been
freed. Move FW crashed check using event_data after
posting event.

Change-Id: Ie82a0b7b4ceb40063318ab2d926b9c14412fb2c9
Signed-off-by: default avatarNaman Padhiar <quic_npadhiar@quicinc.com>
parent 41d11b26

drivers/soc/qcom/icnss2/main.c

+3 −2
Original line number Diff line number Diff line
@@ -2029,12 +2029,13 @@ static int icnss_service_notifier_notify(struct notifier_block *nb, 
	}



	clear_bit(ICNSS_HOST_TRIGGERED_PDR, &priv->state);

	icnss_driver_event_post(priv, ICNSS_DRIVER_EVENT_PD_SERVICE_DOWN,

				ICNSS_EVENT_SYNC, event_data);



	if (event_data->crashed)

		mod_timer(&priv->recovery_timer,

			  jiffies + msecs_to_jiffies(ICNSS_RECOVERY_TIMEOUT));



	icnss_driver_event_post(priv, ICNSS_DRIVER_EVENT_PD_SERVICE_DOWN,

				ICNSS_EVENT_SYNC, event_data);

done:

	if (notification == SERVREG_NOTIF_SERVICE_STATE_UP_V01)

		clear_bit(ICNSS_FW_DOWN, &priv->state);