Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abf4923e authored by Hsin-Yi Wang's avatar Hsin-Yi Wang Committed by Wolfram Sang
Browse files

i2c: mediatek: disable zero-length transfers for mt8183 



Quoting from mt8183 datasheet, the number of transfers to be
transferred in one transaction should be set to bigger than 1,
so we should forbid zero-length transfer and update functionality.

Reported-by: default avatarAlexandru M Stan <amstan@chromium.org>
Signed-off-by: default avatarHsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: default avatarQii Wang <qii.wang@mediatek.com>
[wsa: shortened commit message a little]
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent b3d604d4

drivers/i2c/busses/i2c-mt65xx.c

+10 −1
Original line number Diff line number Diff line
@@ -234,6 +234,10 @@ static const struct i2c_adapter_quirks mt7622_i2c_quirks = { 
	.max_num_msgs = 255,

};



static const struct i2c_adapter_quirks mt8183_i2c_quirks = {

	.flags = I2C_AQ_NO_ZERO_LEN,

};



static const struct mtk_i2c_compatible mt2712_compat = {

	.regs = mt_i2c_regs_v1,

	.pmic_i2c = 0,
@@ -298,6 +302,7 @@ static const struct mtk_i2c_compatible mt8173_compat = { 
};



static const struct mtk_i2c_compatible mt8183_compat = {

	.quirks = &mt8183_i2c_quirks,

	.regs = mt_i2c_regs_v2,

	.pmic_i2c = 0,

	.dcm = 0,
@@ -870,6 +875,10 @@ static irqreturn_t mtk_i2c_irq(int irqno, void *dev_id) 


static u32 mtk_i2c_functionality(struct i2c_adapter *adap)

{

	if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)

		return I2C_FUNC_I2C |

			(I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK);

	else

		return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;

}