Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abe5b47c authored by Fabio Estevam's avatar Fabio Estevam Committed by Lee Jones
Browse files

mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag 



Since commit 1c6c6952 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent b3c8c82b

drivers/mfd/ab8500-debugfs.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2885,7 +2885,7 @@ static ssize_t ab8500_subscribe_write(struct file *file, 
	}

	}





	err = request_threaded_irq(user_val, NULL, ab8500_debug_handler,

	err = request_threaded_irq(user_val, NULL, ab8500_debug_handler,

				   IRQF_SHARED | IRQF_NO_SUSPEND,

				   IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,

				   "ab8500-debug", &dev->kobj);

				   "ab8500-debug", &dev->kobj);

	if (err < 0) {

	if (err < 0) {

		pr_info("request_threaded_irq failed %d, %lu\n",

		pr_info("request_threaded_irq failed %d, %lu\n",