Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aba9777a authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by David S. Miller
Browse files

amd-xgbe: Add a workaround for Tx timestamp issue 



Update the reading of the Tx timestamp to account for a hardware issue
on how the fields and interrupt are cleared.  The "seconds" portion of
the timestamp should be read first, followed by the "nanoseconds" portion.
Reading the "nanoseconds" portion should clear the timestamp data and the
interrupt.  Because of an issue with the hardware this order is reversed
and reading the "seconds" portion actually clears the timestamp.  The code
currently follows this workaround, but to guard against future versions
where this is fixed add a field to the version data to indicate if the
workaround is required or not.

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ffc0335

drivers/net/ethernet/amd/xgbe/xgbe-dev.c

+10 −3
Original line number Diff line number Diff line
@@ -1360,14 +1360,21 @@ static u64 xgbe_get_tstamp_time(struct xgbe_prv_data *pdata) 


static u64 xgbe_get_tx_tstamp(struct xgbe_prv_data *pdata)

{

	unsigned int tx_snr;

	unsigned int tx_snr, tx_ssr;

	u64 nsec;



	if (pdata->vdata->tx_tstamp_workaround) {

		tx_snr = XGMAC_IOREAD(pdata, MAC_TXSNR);

		tx_ssr = XGMAC_IOREAD(pdata, MAC_TXSSR);

	} else {

		tx_ssr = XGMAC_IOREAD(pdata, MAC_TXSSR);

		tx_snr = XGMAC_IOREAD(pdata, MAC_TXSNR);

	}



	if (XGMAC_GET_BITS(tx_snr, MAC_TXSNR, TXTSSTSMIS))

		return 0;



	nsec = XGMAC_IOREAD(pdata, MAC_TXSSR);

	nsec = tx_ssr;

	nsec *= NSEC_PER_SEC;

	nsec += tx_snr;

drivers/net/ethernet/amd/xgbe/xgbe-platform.c

+1 −0
Original line number Diff line number Diff line
@@ -581,6 +581,7 @@ static const struct xgbe_version_data xgbe_v1 = { 
	.xpcs_access			= XGBE_XPCS_ACCESS_V1,

	.tx_max_fifo_size		= 81920,

	.rx_max_fifo_size		= 81920,

	.tx_tstamp_workaround		= 1,

};



#ifdef CONFIG_ACPI

drivers/net/ethernet/amd/xgbe/xgbe.h

+1 −0
Original line number Diff line number Diff line
@@ -805,6 +805,7 @@ struct xgbe_version_data { 
	unsigned int mmc_64bit;

	unsigned int tx_max_fifo_size;

	unsigned int rx_max_fifo_size;

	unsigned int tx_tstamp_workaround;

};



struct xgbe_prv_data {