Commit ab9a953b authored Aug 11, 2015 by Mauro Carvalho Chehab

[media] ov2659: get rid of unused values



Why to store the chosed values for prediv, postdiv and mult if
those won't be used?

drivers/media/i2c/ov2659.c: In function 'ov2659_pll_calc_params':
drivers/media/i2c/ov2659.c:912:35: warning: variable 's_mult' set but not used [-Wunused-but-set-variable]
  u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
                                   ^
drivers/media/i2c/ov2659.c:912:20: warning: variable 's_postdiv' set but not used [-Wunused-but-set-variable]
  u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
                    ^
drivers/media/i2c/ov2659.c:912:6: warning: variable 's_prediv' set but not used [-Wunused-but-set-variable]
  u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
      ^

This is likely some leftover from some past change.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 12976516

drivers/media/i2c/ov2659.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -909,7 +909,6 @@ static void ov2659_pll_calc_params(struct ov2659 *ov2659)
		u8 ctrl1_reg = 0, ctrl2_reg = 0, ctrl3_reg = 0;
		struct i2c_client *client = ov2659->client;
		unsigned int desired = pdata->link_frequency;
		u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
		u32 prediv, postdiv, mult;
		u32 bestdelta = -1;
		u32 delta, actual;
		@@ -929,9 +928,6 @@ static void ov2659_pll_calc_params(struct ov2659 *ov2659)

		if ((delta < bestdelta) \|\| (bestdelta == -1)) {
		bestdelta = delta;
		s_mult = mult;
		s_prediv = prediv;
		s_postdiv = postdiv;
		ctrl1_reg = ctrl1[i].reg;
		ctrl2_reg = mult;
		ctrl3_reg = ctrl3[j].reg;