Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab9a6883 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mauro Carvalho Chehab
Browse files

media: staging: atomisp: Remove ->power_ctrl() callback 



There is redundant callback which does nothing in upstreamed version of
the driver.

Remove it along with user call places.

Mostly done with help of coccinelle.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 32471bda

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

+0 −4
Original line number Diff line number Diff line
@@ -737,10 +737,6 @@ static int power_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->power_ctrl)

		return dev->platform_data->power_ctrl(sd, flag);



	if (flag) {

		/* The upstream module driver (written to Crystal

		 * Cove) had this logic to pulse the rails low first.

drivers/staging/media/atomisp/i2c/atomisp-gc2235.c

+0 −4
Original line number Diff line number Diff line
@@ -547,10 +547,6 @@ static int power_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->power_ctrl)

		return dev->platform_data->power_ctrl(sd, flag);



	if (flag) {

		ret = dev->platform_data->v1p8_ctrl(sd, 1);

		usleep_range(60, 90);

drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c

+0 −4
Original line number Diff line number Diff line
@@ -454,10 +454,6 @@ static int power_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->power_ctrl)

		return dev->platform_data->power_ctrl(sd, flag);



	if (flag) {

		ret = dev->platform_data->v2p8_ctrl(sd, 1);

		if (ret == 0) {

drivers/staging/media/atomisp/i2c/atomisp-ov2680.c

+0 −4
Original line number Diff line number Diff line
@@ -846,10 +846,6 @@ static int power_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->power_ctrl)

		return dev->platform_data->power_ctrl(sd, flag);



	if (flag) {

		ret |= dev->platform_data->v1p8_ctrl(sd, 1);

		ret |= dev->platform_data->v2p8_ctrl(sd, 1);

drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

+0 −4
Original line number Diff line number Diff line
@@ -650,10 +650,6 @@ static int power_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->power_ctrl)

		return dev->platform_data->power_ctrl(sd, flag);



	if (flag) {

		ret = dev->platform_data->v1p8_ctrl(sd, 1);

		if (ret == 0) {