Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab73ef46 authored by Nikolay Borisov's avatar Nikolay Borisov Committed by Jan Kara
Browse files

quota: Fix possible GPF due to uninitialised pointers 



When dqget() in __dquot_initialize() fails e.g. due to IO error,
__dquot_initialize() will pass an array of uninitialized pointers to
dqput_all() and thus can lead to deference of random data. Fix the
problem by properly initializing the array.

CC: stable@vger.kernel.org
Signed-off-by: default avatarNikolay Borisov <kernel@kyup.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 6332b9b5

fs/quota/dquot.c

+1 −2
Original line number Diff line number Diff line
@@ -1410,7 +1410,7 @@ static int dquot_active(const struct inode *inode) 
static int __dquot_initialize(struct inode *inode, int type)

{

	int cnt, init_needed = 0;

	struct dquot **dquots, *got[MAXQUOTAS];

	struct dquot **dquots, *got[MAXQUOTAS] = {};

	struct super_block *sb = inode->i_sb;

	qsize_t rsv;

	int ret = 0;
@@ -1427,7 +1427,6 @@ static int __dquot_initialize(struct inode *inode, int type) 
		int rc;

		struct dquot *dquot;



		got[cnt] = NULL;

		if (type != -1 && cnt != type)

			continue;

		/*