Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab6211c9 authored by Will Deacon's avatar Will Deacon
Browse files

arm64: debug: Clean up brk_handler() 



brk_handler() now looks pretty strange and can be refactored to drop its
funny 'handler_found' local variable altogether.

Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 453b7740

arch/arm64/kernel/debug-monitors.c

+4 −6
Original line number Diff line number Diff line
@@ -331,14 +331,12 @@ NOKPROBE_SYMBOL(call_break_hook); 
static int brk_handler(unsigned long unused, unsigned int esr,

		       struct pt_regs *regs)

{

	bool handler_found = false;



	if (!handler_found && call_break_hook(regs, esr) == DBG_HOOK_HANDLED)

		handler_found = true;

	if (call_break_hook(regs, esr) == DBG_HOOK_HANDLED)

		return 0;



	if (!handler_found && user_mode(regs)) {

	if (user_mode(regs)) {

		send_user_sigtrap(TRAP_BRKPT);

	} else if (!handler_found) {

	} else {

		pr_warn("Unexpected kernel BRK exception at EL1\n");

		return -EFAULT;

	}