Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab5098fa authored by Olivier Matz's avatar Olivier Matz Committed by David S. Miller
Browse files

ip6_gre: fix tunnel list corruption for x-netns 



In changelink ops, the ip6gre_net pointer is retrieved from
dev_net(dev), which is wrong in case of x-netns. Thus, the tunnel is not
unlinked from its current list and is relinked into another net
namespace. This corrupts the tunnel lists and can later trigger a kernel
oops.

Fix this by retrieving the netns from device private area.

Fixes: c8632fc3 ("net: ip6_gre: Split up ip6gre_changelink()")
Cc: Petr Machata <petrm@mellanox.com>
Signed-off-by: default avatarOlivier Matz <olivier.matz@6wind.com>
Acked-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 72f6d4d1

net/ipv6/ip6_gre.c

+2 −2
Original line number Diff line number Diff line
@@ -2025,9 +2025,9 @@ static int ip6gre_changelink(struct net_device *dev, struct nlattr *tb[], 
			     struct nlattr *data[],

			     struct netlink_ext_ack *extack)

{

	struct ip6gre_net *ign = net_generic(dev_net(dev), ip6gre_net_id);

	struct ip6_tnl *t = netdev_priv(dev);

	struct ip6gre_net *ign = net_generic(t->net, ip6gre_net_id);

	struct __ip6_tnl_parm p;

	struct ip6_tnl *t;



	t = ip6gre_changelink_common(dev, tb, data, &p, extack);

	if (IS_ERR(t))