Commit aae35081 authored Jul 26, 2022 by Bryan O'Donoghue Committed by Greg Kroah-Hartman Oct 29, 2022

media: venus: dec: Handle the case where find_format fails



commit 06a2da340f762addc5935bf851d95b14d4692db2 upstream.

Debugging the decoder on msm8916 I noticed the vdec probe was crashing if
the fmt pointer was NULL.

A similar fix from Colin Ian King found by Coverity was implemented for the
encoder. Implement the same fix on the decoder.

Fixes: 7472c1c6 ("[media] media: venus: vdec: add video decoder files")
Cc: stable@vger.kernel.org  # v4.13+
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fd596e73

drivers/media/platform/qcom/venus/vdec.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -157,6 +157,8 @@ vdec_try_fmt_common(struct venus_inst inst, struct v4l2_format f)
		else
		return NULL;
		fmt = find_format(inst, pixmp->pixelformat, f->type);
		if (!fmt)
		return NULL;
		}

		pixmp->width = clamp(pixmp->width, frame_width_min(inst),