Commit aa8b187e authored Aug 09, 2016 by Guenter Roeck

hwmon: (it87) Features mask must be 32 bit wide



Coverity reports:

result_independent_of_operands: data->features & (65536UL /* 1UL << 16 */)
is always 0 regardless of the values of its operands. This occurs as the
logical operand of if.

data->features needs to be 32 bit wide since there are more than 16 features.

Fixes: cc18da79 ("hwmon: (it87) Support up to 6 temperature sensors ... ");
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 29b4817d

drivers/hwmon/it87.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -491,7 +491,7 @@ struct it87_sio_data {
	struct it87_data {		struct it87_data {
	const struct attribute_group *groups[7];		const struct attribute_group *groups[7];
	enum chips type;		enum chips type;
	u16 features;		u32 features;
	u8 peci_mask;		u8 peci_mask;
	u8 old_peci_mask;		u8 old_peci_mask;