Commit aa52acef authored Sep 20, 2022 by Isaac J. Manjarres Committed by Greg Kroah-Hartman Jan 18, 2023

driver core: Fix bus_type.match() error handling in __driver_attach()



commit 27c0d217340e47ec995557f61423ef415afba987 upstream.

When a driver registers with a bus, it will attempt to match with every
device on the bus through the __driver_attach() function. Currently, if
the bus_type.match() function encounters an error that is not
-EPROBE_DEFER, __driver_attach() will return a negative error code, which
causes the driver registration logic to stop trying to match with the
remaining devices on the bus.

This behavior is not correct; a failure while matching a driver to a
device does not mean that the driver won't be able to match and bind
with other devices on the bus. Update the logic in __driver_attach()
to reflect this.

Fixes: 656b8035 ("ARM: 8524/1: driver cohandle -EPROBE_DEFER from bus_type.match()")
Cc: stable@vger.kernel.org
Cc: Saravana Kannan <saravanak@google.com>
Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
Link: https://lore.kernel.org/r/20220921001414.4046492-1-isaacmanjarres@google.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8d60a905

drivers/base/dd.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1068,8 +1068,12 @@ static int __driver_attach(struct device dev, void data)
		*/
		return 0;
		} else if (ret < 0) {
		dev_dbg(dev, "Bus failed to match device: %d", ret);
		return ret;
		dev_dbg(dev, "Bus failed to match device: %d\n", ret);
		/*
		* Driver could not match with device, but may match with
		* another device on the bus.
		*/
		return 0;
		} /* ret > 0 means positive match */

		if (driver_allows_async_probing(drv)) {