Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa3932eb authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Greg Kroah-Hartman
Browse files

pinctrl: at91-pio4: check return value of devm_kasprintf() 



[ Upstream commit f6fd5d4ff8ca0b24cee1af4130bcb1fa96b61aa0 ]

devm_kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 77618084 ("pinctrl: introduce driver for Atmel PIO4 controller")
Depends-on: 1c4e5c470a56 ("pinctrl: at91: use devm_kasprintf() to avoid potential leaks")
Depends-on: 5a8f9cf269e8 ("pinctrl: at91-pio4: use proper format specifier for unsigned int")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230615105333.585304-4-claudiu.beznea@microchip.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e297350c

drivers/pinctrl/pinctrl-at91-pio4.c

+2 −0
Original line number Diff line number Diff line
@@ -1013,6 +1013,8 @@ static int atmel_pinctrl_probe(struct platform_device *pdev) 
		/* Pin naming convention: P(bank_name)(bank_pin_number). */

		pin_desc[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "P%c%d",

						  bank + 'A', line);

		if (!pin_desc[i].name)

			return -ENOMEM;



		group->name = group_names[i] = pin_desc[i].name;

		group->pin = pin_desc[i].number;