Commit aa2ba356 authored Nov 11, 2022 by Gaosheng Cui Committed by Greg Kroah-Hartman Nov 25, 2022

bnxt_en: Remove debugfs when pci_register_driver failed



[ Upstream commit 991aef4ee4f6eb999924f429b943441a32835c8f ]

When pci_register_driver failed, we need to remove debugfs,
which will caused a resource leak, fix it.

Resource leak logs as follows:
[   52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present!

Fixes: cabfb09d ("bnxt_en: add debugfs support for DIM")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 6134357f

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -12232,8 +12232,16 @@ static struct pci_driver bnxt_pci_driver = {

		static int __init bnxt_init(void)
		{
		int err;

		bnxt_debug_init();
		return pci_register_driver(&bnxt_pci_driver);
		err = pci_register_driver(&bnxt_pci_driver);
		if (err) {
		bnxt_debug_exit();
		return err;
		}

		return 0;
		}

		static void __exit bnxt_exit(void)