Commit aa28b98d authored Sep 06, 2019 by Colin Ian King Committed by Gabriel Krisman Bertazi Sep 17, 2019

unicode: make array 'token' static const, makes object smaller



Don't populate the array 'token' on the stack but instead make it
static const. Makes the object code smaller by 234 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
   5371	    272	      0	   5643	   160b	fs/unicode/utf8-core.o

After:
   text	   data	    bss	    dec	    hex	filename
   5041	    368	      0	   5409	   1521	fs/unicode/utf8-core.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

parent 334b427e

fs/unicode/utf8-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -154,7 +154,7 @@ static int utf8_parse_version(const char version, unsigned int maj,
		{
		substring_t args[3];
		char version_string[12];
		const struct match_token token[] = {
		static const struct match_token token[] = {
		{1, "%d.%d.%d"},
		{0, NULL}
		};