Commit a96a8a57 authored May 10, 2019 by Colin Ian King Committed by Jiri Kosina May 22, 2019

HID: logitech-hidpp: HID: make const array consumer_rdesc_start static



Don't populate the array consumer_rdesc_start on the stack but instead
make it static. Makes the object code smaller by 88 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  59155	   9840	    448	  69443	  10f43	drivers/hid/hid-logitech-hidpp.o

After:
   text	   data	    bss	    dec	    hex	filename
  59003	   9904	    448	  69355	  10eeb	drivers/hid/hid-logitech-hidpp.o

(gcc version 8.3.0, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 39d21e7e

drivers/hid/hid-logitech-hidpp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2862,7 +2862,7 @@ static u8 hidpp10_consumer_keys_report_fixup(struct hidpp_device hidpp,
		u8 _rdesc, unsigned int rsize)
		{
		/* Note 0 terminated so we can use strnstr to search for this. */
		const char consumer_rdesc_start[] = {
		static const char consumer_rdesc_start[] = {
		0x05, 0x0C, /* USAGE_PAGE (Consumer Devices) */
		0x09, 0x01, /* USAGE (Consumer Control) */
		0xA1, 0x01, /* COLLECTION (Application) */