Commit a95049c5 authored Nov 12, 2020 by Zheng Liang Committed by Greg Kroah-Hartman Jan 06, 2021

rtc: pl031: fix resource leak in pl031_probe



[ Upstream commit 1eab0fea2514b269e384c117f5b5772b882761f0 ]

When devm_rtc_allocate_device is failed in pl031_probe, it should release
mem regions with device.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Liang <zhengliang6@huawei.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20201112093139.32566-1-zhengliang6@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e2926630

drivers/rtc/rtc-pl031.c

+4 −2

Original line number	Original line	Diff line number	Diff line
	@@ -379,8 +379,10 @@ static int pl031_probe(struct amba_device adev, const struct amba_id id)

	device_init_wakeup(&adev->dev, true);		device_init_wakeup(&adev->dev, true);
	ldata->rtc = devm_rtc_allocate_device(&adev->dev);		ldata->rtc = devm_rtc_allocate_device(&adev->dev);
	if (IS_ERR(ldata->rtc))		if (IS_ERR(ldata->rtc)) {
	return PTR_ERR(ldata->rtc);		ret = PTR_ERR(ldata->rtc);
			goto out;
			}

	ldata->rtc->ops = ops;		ldata->rtc->ops = ops;