Commit a94c689e authored Jul 31, 2018 by Florian Fainelli Committed by David S. Miller Aug 01, 2018

net: dsa: Do not suspend/resume closed slave_dev



If a DSA slave network device was previously disabled, there is no need
to suspend or resume it.

Fixes: 24462549 ("net: dsa: allow switch drivers to implement suspend/resume hooks")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bc5b6c0b

net/dsa/slave.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1248,6 +1248,9 @@ int dsa_slave_suspend(struct net_device *slave_dev)
		{
		struct dsa_port *dp = dsa_slave_to_port(slave_dev);

		if (!netif_running(slave_dev))
		return 0;

		netif_device_detach(slave_dev);

		rtnl_lock();
		@@ -1261,6 +1264,9 @@ int dsa_slave_resume(struct net_device *slave_dev)
		{
		struct dsa_port *dp = dsa_slave_to_port(slave_dev);

		if (!netif_running(slave_dev))
		return 0;

		netif_device_attach(slave_dev);

		rtnl_lock();