Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9047734 authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Daniel Borkmann
Browse files

selftests/bpf: add missing \n to flow_dissector CHECK errors 



Otherwise, in case of an error, everything gets mushed together.

Fixes: a5cb3346 ("selftests/bpf: make flow dissector tests more extensible")
Signed-off-by: default avatarStanislav Fomichev <sdf@google.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 15ea164e

tools/testing/selftests/bpf/prog_tests/flow_dissector.c

+4 −4
Original line number Diff line number Diff line
@@ -242,12 +242,12 @@ void test_flow_dissector(void) 
	 */



	err = bpf_prog_attach(prog_fd, 0, BPF_FLOW_DISSECTOR, 0);

	CHECK(err, "bpf_prog_attach", "err %d errno %d", err, errno);

	CHECK(err, "bpf_prog_attach", "err %d errno %d\n", err, errno);



	tap_fd = create_tap("tap0");

	CHECK(tap_fd < 0, "create_tap", "tap_fd %d errno %d", tap_fd, errno);

	CHECK(tap_fd < 0, "create_tap", "tap_fd %d errno %d\n", tap_fd, errno);

	err = ifup("tap0");

	CHECK(err, "ifup", "err %d errno %d", err, errno);

	CHECK(err, "ifup", "err %d errno %d\n", err, errno);



	for (i = 0; i < ARRAY_SIZE(tests); i++) {

		struct bpf_flow_keys flow_keys = {};
@@ -255,7 +255,7 @@ void test_flow_dissector(void) 
		__u32 key = 0;



		err = tx_tap(tap_fd, &tests[i].pkt, sizeof(tests[i].pkt));

		CHECK(err < 0, "tx_tap", "err %d errno %d", err, errno);

		CHECK(err < 0, "tx_tap", "err %d errno %d\n", err, errno);



		err = bpf_map_lookup_elem(keys_fd, &key, &flow_keys);

		CHECK_ATTR(err, tests[i].name, "bpf_map_lookup_elem %d\n", err);