Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8baccb7 authored by Zeng Heng's avatar Zeng Heng Committed by Greg Kroah-Hartman
Browse files

ASoC: pxa: fix null-pointer dereference in filter() 



[ Upstream commit ec7bf231aaa1bdbcb69d23bc50c753c80fb22429 ]

kasprintf() would return NULL pointer when kmalloc() fail to allocate.
Need to check the return pointer before calling strcmp().

Fixes: 7a824e21 ("ASoC: mmp: add audio dma support")
Signed-off-by: default avatarZeng Heng <zengheng4@huawei.com>
Link: https://lore.kernel.org/r/20221114085629.1910435-1-zengheng4@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6f13a895

sound/soc/pxa/mmp-pcm.c

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static bool filter(struct dma_chan *chan, void *param) 


	devname = kasprintf(GFP_KERNEL, "%s.%d", dma_data->dma_res->name,

		dma_data->ssp_id);

	if ((strcmp(dev_name(chan->device->dev), devname) == 0) &&

	if (devname && (strcmp(dev_name(chan->device->dev), devname) == 0) &&

		(chan->chan_id == dma_data->dma_res->start)) {

		found = true;

	}