Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit a8939766 authored by Giulio Benetti's avatar Giulio Benetti Committed by Maxime Ripard
Browse files

drm/sun4i: tcon: prevent tcon->panel dereference if NULL 



If tcon->panel pointer is NULL, trying to dereference from it
(i.e. tcon->panel->connector) will cause a null pointer dereference.

Add tcon->panel null pointer check before calling
sun4i_tcon0_mode_set_dithering().

Signed-off-by: default avatarGiulio Benetti <giulio.benetti@micronovasrl.com>
Fixes: f11adcec ("drm/sun4i: tcon: Add dithering support for
                      RGB565/RGB666 LCD panels")
Reviewed-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181005215951.99003-2-giulio.benetti@micronovasrl.com
parent 7f4cedd8

drivers/gpu/drm/sun4i/sun4i_tcon.c

+2 −1
Original line number Diff line number Diff line
@@ -491,6 +491,7 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, 
	sun4i_tcon0_mode_set_common(tcon, mode);



	/* Set dithering if needed */

	if (tcon->panel)

		sun4i_tcon0_mode_set_dithering(tcon, tcon->panel->connector);



	/* Adjust clock delay */