Commit a718d79c authored Mar 30, 2011 by Peter Hutterer Committed by Dmitry Torokhov Mar 31, 2011

Input: uinput - allow for 0/0 min/max on absolute axes.



Some devices provide absolute axes with min/max of 0/0 (e.g. wacom's
ABS_MISC axis). Current uinput restrictions do not allow duplication of
these devices and require hacks in userspace to work around this.

If the kernel accepts physical devices with a min/max of 0/0, uinput
shouldn't disallow the same range.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

parent 170531ba

drivers/input/misc/uinput.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -302,10 +302,14 @@ static int uinput_validate_absbits(struct input_dev *dev)
		int retval = 0;

		for (cnt = 0; cnt < ABS_CNT; cnt++) {
		int min, max;
		if (!test_bit(cnt, dev->absbit))
		continue;

		if (input_abs_get_max(dev, cnt) <= input_abs_get_min(dev, cnt)) {
		min = input_abs_get_min(dev, cnt);
		max = input_abs_get_max(dev, cnt);

		if ((min != 0 \|\| max != 0) && max <= min) {
		printk(KERN_DEBUG
		"%s: invalid abs[%02x] min:%d max:%d\n",
		UINPUT_NAME, cnt,