Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7163dc2 authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: core: remove outdated DEBUG output 



The usefulness of this debug output is questionable. It covers only
direct i2c_transfer calls and no SMBUS calls, neither direct nor
emulated ones. And the latter one is largely used in the kernel, so a
lot of stuff is missed. False positives are also generated in case the
locking later fails. Also, we have a proper tracing mechanism for all
these kinds of transfers in place for years now. Remove this old one.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: default avatarPeter Rosin <peda@axentia.se>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent e2115ace

drivers/i2c/i2c-core-base.c

+0 −10
Original line number Diff line number Diff line
@@ -1940,16 +1940,6 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) 
	 */



	if (adap->algo->master_xfer) {

#ifdef DEBUG

		for (ret = 0; ret < num; ret++) {

			dev_dbg(&adap->dev,

				"master_xfer[%d] %c, addr=0x%02x, len=%d%s\n",

				ret, (msgs[ret].flags & I2C_M_RD) ? 'R' : 'W',

				msgs[ret].addr, msgs[ret].len,

				(msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : "");

		}

#endif



		if (in_atomic() || irqs_disabled()) {

			ret = i2c_trylock_bus(adap, I2C_LOCK_SEGMENT);

			if (!ret)