Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7117f81 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Sebastian Reichel
Browse files

power_supply: lp8788-charger: Fix leaked power supply on probe fail



Driver forgot to unregister charger power supply if registering of
battery supply failed in probe(). In such case the memory associated
with power supply leaked.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 98a27664 ("power_supply: Add new lp8788 charger driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent a2c1d531
Loading
Loading
Loading
Loading
+3 −1
Original line number Original line Diff line number Diff line
@@ -417,8 +417,10 @@ static int lp8788_psy_register(struct platform_device *pdev,
	pchg->battery.num_properties = ARRAY_SIZE(lp8788_battery_prop);
	pchg->battery.num_properties = ARRAY_SIZE(lp8788_battery_prop);
	pchg->battery.get_property = lp8788_battery_get_property;
	pchg->battery.get_property = lp8788_battery_get_property;


	if (power_supply_register(&pdev->dev, &pchg->battery))
	if (power_supply_register(&pdev->dev, &pchg->battery)) {
		power_supply_unregister(&pchg->charger);
		return -EPERM;
		return -EPERM;
	}


	return 0;
	return 0;
}
}