Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a70ab8a8 authored by Charles Keepax's avatar Charles Keepax Committed by Takashi Iwai
Browse files

ALSA: compress: Don't allow paritial drain operations on capture streams 



Partial drain and next track are intended for gapless playback and
don't really have an obvious interpretation for a capture stream, so
makes sense to not allow those operations on capture streams.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 26c3f154

sound/core/compress_offload.c

+8 −0
Original line number Diff line number Diff line
@@ -834,6 +834,10 @@ static int snd_compr_next_track(struct snd_compr_stream *stream) 
	if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING)

		return -EPERM;



	/* next track doesn't have any meaning for capture streams */

	if (stream->direction == SND_COMPRESS_CAPTURE)

		return -EPERM;



	/* you can signal next track if this is intended to be a gapless stream

	 * and current track metadata is set

	 */
@@ -861,6 +865,10 @@ static int snd_compr_partial_drain(struct snd_compr_stream *stream) 
		break;

	}



	/* partial drain doesn't have any meaning for capture streams */

	if (stream->direction == SND_COMPRESS_CAPTURE)

		return -EPERM;



	/* stream can be drained only when next track has been signalled */

	if (stream->next_track == false)

		return -EPERM;