Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7082daa authored by Arvind Yadav's avatar Arvind Yadav Committed by Greg Kroah-Hartman
Browse files

coresight: use put_device() instead of kfree() 



Never directly free @dev after calling device_register(), even
if it returned an error. Always use put_device() to give up the
reference initialized.

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a93e7b33

drivers/hwtracing/coresight/coresight.c

+4 −4
Original line number Diff line number Diff line
@@ -1026,8 +1026,10 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) 
	dev_set_name(&csdev->dev, "%s", desc->pdata->name);



	ret = device_register(&csdev->dev);

	if (ret)

		goto err_device_register;

	if (ret) {

		put_device(&csdev->dev);

		goto err_kzalloc_csdev;

	}



	mutex_lock(&coresight_mutex);
@@ -1038,8 +1040,6 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) 


	return csdev;



err_device_register:

	kfree(conns);

err_kzalloc_conns:

	kfree(refcnts);

err_kzalloc_refcnts: