Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a705f9c1 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

pinctrl: baytrail: Use defined macro instead of magic in byt_get_gpio_mux() 



By the fact byt_get_gpio_mux() returns a value of mux settings as
it is represented in hardware. Use defined macro instead of magic numbers
to clarify this.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20190703003018.75186-1-andriy.shevchenko@linux.intel.com


Reviewed-By: default avatarEnrico Weigelt <info@metux.net>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 57218371

drivers/pinctrl/intel/pinctrl-baytrail.c

+4 −3
Original line number Original line Diff line number Diff line
@@ -91,6 +91,7 @@ 
 * does not find a match for the requested function.

 * does not find a match for the requested function.

 */

 */

#define BYT_DEFAULT_GPIO_MUX	0

#define BYT_DEFAULT_GPIO_MUX	0

#define BYT_ALTER_GPIO_MUX	1





struct byt_gpio_pin_context {

struct byt_gpio_pin_context {

	u32 conf0;

	u32 conf0;
@@ -932,14 +933,14 @@ static u32 byt_get_gpio_mux(struct byt_gpio *vg, unsigned int offset) 
	/* SCORE pin 92-93 */

	/* SCORE pin 92-93 */

	if (!strcmp(vg->soc_data->uid, BYT_SCORE_ACPI_UID) &&

	if (!strcmp(vg->soc_data->uid, BYT_SCORE_ACPI_UID) &&

	    offset >= 92 && offset <= 93)

	    offset >= 92 && offset <= 93)

		return 1;

		return BYT_ALTER_GPIO_MUX;





	/* SUS pin 11-21 */

	/* SUS pin 11-21 */

	if (!strcmp(vg->soc_data->uid, BYT_SUS_ACPI_UID) &&

	if (!strcmp(vg->soc_data->uid, BYT_SUS_ACPI_UID) &&

	    offset >= 11 && offset <= 21)

	    offset >= 11 && offset <= 21)

		return 1;

		return BYT_ALTER_GPIO_MUX;





	return 0;

	return BYT_DEFAULT_GPIO_MUX;

}

}





static void byt_gpio_clear_triggering(struct byt_gpio *vg, unsigned int offset)

static void byt_gpio_clear_triggering(struct byt_gpio *vg, unsigned int offset)