Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6e4599f authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: uda134x: Remove is_powered_on_standby from platform data 



According to its documentation the is_powered_on_standby field of the
uda134x platform data is supposed to prevent the the driver from shutting
down the ADC and DAC in standby mode. This behavior was broken in commit
commit f0fba2ad ("ASoC: multi-component - ASoC Multi-Component Support")
almost 5 years ago and all the flag does now is cause the driver to go to
SND_SOC_BIAS_ON in probe, just for the ASoC core to put it back into
SND_SOC_BIAS_STANDBY right after probe.

Apparently the intended behavior has not been missed, so just remove
is_powered_on_standby from the platform data struct.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f114040e

include/sound/uda134x.h

+0 −12
Original line number Diff line number Diff line
@@ -18,18 +18,6 @@ struct uda134x_platform_data { 
	struct l3_pins l3;

	void (*power) (int);

	int model;

	/*

	  ALSA SOC usually puts the device in standby mode when it's not used

	  for sometime. If you unset is_powered_on_standby the driver will

	  turn off the ADC/DAC when this callback is invoked and turn it back

	  on when needed. Unfortunately this will result in a very light bump

	  (it can be audible only with good earphones). If this bothers you

	  set is_powered_on_standby, you will have slightly higher power

	  consumption. Please note that sending the L3 command for ADC is

	  enough to make the bump, so it doesn't make difference if you

	  completely take off power from the codec.

	*/

	int is_powered_on_standby;

#define UDA134X_UDA1340 1

#define UDA134X_UDA1341 2

#define UDA134X_UDA1344 3

sound/soc/codecs/uda134x.c

+1 −4
Original line number Diff line number Diff line
@@ -518,9 +518,6 @@ static int uda134x_soc_probe(struct snd_soc_codec *codec) 


	uda134x_reset(codec);



	if (pd->is_powered_on_standby)

		uda134x_set_bias_level(codec, SND_SOC_BIAS_ON);

	else

	uda134x_set_bias_level(codec, SND_SOC_BIAS_STANDBY);



	if (pd->model == UDA134X_UDA1341) {