Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6650d27 authored by Zheng Wang's avatar Zheng Wang Committed by Greg Kroah-Hartman
Browse files

Bluetooth: btsdio: fix use after free bug in btsdio_remove due to race condition 



commit 73f7b171b7c09139eb3c6a5677c200dc1be5f318 upstream.

In btsdio_probe, the data->work is bound with btsdio_work. It will be
started in btsdio_send_frame.

If the btsdio_remove runs with a unfinished work, there may be a race
condition that hdev is freed but used in btsdio_work. Fix it by
canceling the work before do cleanup in btsdio_remove.

Fixes: CVE-2023-1989
Fixes: ddbaf13e ("[Bluetooth] Add generic driver for Bluetooth SDIO devices")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
[ Denis: Added CVE-2023-1989 and fixes tags. ]
Signed-off-by: default avatarDenis Efremov (Oracle) <efremov@linux.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5876cae6

drivers/bluetooth/btsdio.c

+1 −0
Original line number Diff line number Diff line
@@ -346,6 +346,7 @@ static void btsdio_remove(struct sdio_func *func) 
	if (!data)

		return;



	cancel_work_sync(&data->work);

	hdev = data->hdev;



	sdio_set_drvdata(func, NULL);