Commit a638b5de authored Sep 12, 2019 by Jonathan Chocron Committed by Lorenzo Pieralisi Sep 16, 2019

PCI/VPD: Prevent VPD access for Amazon's Annapurna Labs Root Port

The Amazon Annapurna Labs PCIe Root Port exposes the VPD capability,
but there is no actual support for it.

Trying to access the VPD (for example, as part of lspci -vv or when
reading the vpd sysfs file), results in the following warning print:

pcieport 0001:00:00.0: VPD access failed. This is likely a firmware bug on this device. Contact the card vendor for a firmware update

Signed-off-by: Jonathan Chocron <jonnyc@amazon.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>

parent 76e67e9e

drivers/pci/vpd.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -571,6 +571,12 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_LSI_LOGIC, 0x005f, quirk_blacklist_vpd);
		DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID,
		quirk_blacklist_vpd);
		DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_QLOGIC, 0x2261, quirk_blacklist_vpd);
		/*
		* The Amazon Annapurna Labs 0x0031 device id is reused for other non Root Port
		* device types, so the quirk is registered for the PCI_CLASS_BRIDGE_PCI class.
		*/
		DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031,
		PCI_CLASS_BRIDGE_PCI, 8, quirk_blacklist_vpd);

		/*
		* For Broadcom 5706, 5708, 5709 rev. A nics, any read beyond the