Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a635b46b authored by Allan Stephens's avatar Allan Stephens Committed by Paul Gortmaker
Browse files

tipc: Hide internal details of node table implementation 



Relocates information about the size of TIPC's node table index and
its associated hash function, since only node subsystem routines need
to have access to this information.

Note that these changes are essentially cosmetic in nature, and have
no impact on the actual operation of TIPC.

Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 9efde4a0

net/tipc/node.c

+13 −0
Original line number Diff line number Diff line
@@ -39,6 +39,8 @@ 
#include "node.h"

#include "name_distr.h"



#define NODE_HTABLE_SIZE 512



static void node_lost_contact(struct tipc_node *n_ptr);

static void node_established_contact(struct tipc_node *n_ptr);
@@ -50,6 +52,17 @@ static u32 tipc_num_nodes; 


static atomic_t tipc_num_links = ATOMIC_INIT(0);



/*

 * A trivial power-of-two bitmask technique is used for speed, since this

 * operation is done for every incoming TIPC packet. The number of hash table

 * entries has been chosen so that no hash chain exceeds 8 nodes and will

 * usually be much smaller (typically only a single node).

 */

static inline unsigned int tipc_hashfn(u32 addr)

{

	return addr & (NODE_HTABLE_SIZE - 1);

}



/*

 * tipc_node_find - locate specified node object, if it exists

 */

net/tipc/node.h

+0 −12
Original line number Diff line number Diff line
@@ -107,20 +107,8 @@ struct tipc_node { 
	} bclink;

};



#define NODE_HTABLE_SIZE 512

extern struct list_head tipc_node_list;



/*

 * A trivial power-of-two bitmask technique is used for speed, since this

 * operation is done for every incoming TIPC packet. The number of hash table

 * entries has been chosen so that no hash chain exceeds 8 nodes and will

 * usually be much smaller (typically only a single node).

 */

static inline unsigned int tipc_hashfn(u32 addr)

{

	return addr & (NODE_HTABLE_SIZE - 1);

}



struct tipc_node *tipc_node_find(u32 addr);

struct tipc_node *tipc_node_create(u32 addr);

void tipc_node_delete(struct tipc_node *n_ptr);