Commit a5b8db91 authored Mar 13, 2013 by Vlad Yasevich Committed by David S. Miller Mar 17, 2013

rtnetlink: Mask the rta_type when range checking



Range/validity checks on rta_type in rtnetlink_rcv_msg() do
not account for flags that may be set.  This causes the function
to return -EINVAL when flags are set on the type (for example
NLA_F_NESTED).

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8c6216d7

net/core/rtnetlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2621,7 +2621,7 @@ static int rtnetlink_rcv_msg(struct sk_buff skb, struct nlmsghdr nlh)
		struct rtattr attr = (void )nlh + NLMSG_ALIGN(min_len);

		while (RTA_OK(attr, attrlen)) {
		unsigned int flavor = attr->rta_type;
		unsigned int flavor = attr->rta_type & NLA_TYPE_MASK;
		if (flavor) {
		if (flavor > rta_max[sz_idx])
		return -EINVAL;