Commit a56dcc6b authored Nov 13, 2019 by Dan Carpenter Committed by David S. Miller Nov 13, 2019

net: cdc_ncm: Signedness bug in cdc_ncm_set_dgram_size()



This code is supposed to test for negative error codes and partial
reads, but because sizeof() is size_t (unsigned) type then negative
error codes are type promoted to high positive values and the condition
doesn't work as expected.

Fixes: 332f989a ("CDC-NCM: handle incomplete transfer of MTU")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3b5a3997

drivers/net/usb/cdc_ncm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -579,7 +579,7 @@ static void cdc_ncm_set_dgram_size(struct usbnet *dev, int new_size)
		err = usbnet_read_cmd(dev, USB_CDC_GET_MAX_DATAGRAM_SIZE,
		USB_TYPE_CLASS \| USB_DIR_IN \| USB_RECIP_INTERFACE,
		0, iface_no, &max_datagram_size, sizeof(max_datagram_size));
		if (err < sizeof(max_datagram_size)) {
		if (err != sizeof(max_datagram_size)) {
		dev_dbg(&dev->intf->dev, "GET_MAX_DATAGRAM_SIZE failed\n");
		goto out;
		}