Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a56c6980 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: phy: Handle not having GPIO enabled in the kernel 



If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub
function, which return -ENOSYS. Handle this in the same way as
-ENOENT, i.e. assume there is no GPIO used to reset the PHYs.

Reported-by: default avatarChristian Zigotzky <chzigotzky@xenosoft.de>
Tested-by: default avatarChristian Zigotzky <chzigotzky@xenosoft.de>
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Fixes: bafbdd52 ("phylib: Add device reset GPIO support")
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 21a2545b

drivers/net/phy/mdio_bus.c

+2 −1
Original line number Diff line number Diff line
@@ -56,7 +56,8 @@ static int mdiobus_register_gpiod(struct mdio_device *mdiodev) 
		gpiod = fwnode_get_named_gpiod(&mdiodev->dev.of_node->fwnode,

					       "reset-gpios", 0, GPIOD_OUT_LOW,

					       "PHY reset");

	if (PTR_ERR(gpiod) == -ENOENT)

	if (PTR_ERR(gpiod) == -ENOENT ||

	    PTR_ERR(gpiod) == -ENOSYS)

		gpiod = NULL;

	else if (IS_ERR(gpiod))

		return PTR_ERR(gpiod);