Commit a56a5698 authored Sep 27, 2016 by Takashi Sakamoto Committed by Mark Brown Sep 27, 2016

ASoC: da7219: fix inappropriate condition statement



Sparse reports a below warning.

sound/soc/codecs/da7219.c:804:57: warning: dubious: x & !y

The line includes a condition statement; '(a < b) & !c'. Practically, the
evaluated value of this statement equals to the value of '(a < b) && !c'.
Although, it's not an usual way to use bitwise operations as logical
operations to several conditions.

This commit fixes the bug.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent bb0c35fc

sound/soc/codecs/da7219.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -801,7 +801,7 @@ static int da7219_dai_event(struct snd_soc_dapm_widget *w,
	++i;		++i;
	msleep(50);		msleep(50);
	}		}
	} while ((i < DA7219_SRM_CHECK_RETRIES) & (!srm_lock));		} while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock));

	if (!srm_lock)		if (!srm_lock)
	dev_warn(codec->dev, "SRM failed to lock\n");		dev_warn(codec->dev, "SRM failed to lock\n");