Commit a55b316e authored Jun 30, 2012 by Hauke Mehrtens Committed by John W. Linville Jul 10, 2012

brcmsmac: remove PCIE() macro



Instead of checking if there is a PCIe core on the bus, better check if
hosttype is PCIe.

In the original submission to staging PCIE() checked, if the bustype is
PCI and the buscore is a PCIe core. Now we assume that all cores bcma
supports are PCIe based, so we just have to check if the bustype is PCI.

The old code bcmsmac currently uses searches for a PCIe core on the bus
and if there is one assumes that this is the buscore, which is wrong.
Some SoCs have a PCIe core operating in host mode and this is not the
bus core. The old code also caused a null pointer in
ai_get_buscoretype() and ai_get_buscorerev() if buscore was not set
because there was no PCIe core on the bus.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent bdb903e4

drivers/net/wireless/brcm80211/brcmsmac/aiutils.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -318,9 +318,8 @@
		#define IS_SIM(chippkg) \
		((chippkg == HDLSIM_PKG_ID) \|\| (chippkg == HWSIM_PKG_ID))

		#define PCIE(sih) (ai_get_buscoretype(sih) == PCIE_CORE_ID)

		#define PCI_FORCEHT(sih) (PCIE(sih) && (ai_get_chip_id(sih) == BCM4716_CHIP_ID))
		#define PCI_FORCEHT(sih) ((ai_get_buscoretype(sih) == PCIE_CORE_ID) && \
		(ai_get_chip_id(sih) == BCM4716_CHIP_ID))

		#ifdef DEBUG
		#define SI_MSG(fmt, ...) pr_debug(fmt, ##__VA_ARGS__)
		@@ -774,7 +773,7 @@ void ai_pci_up(struct si_pub *sih)
		bcma_core_set_clockmode(cc, BCMA_CLKMODE_FAST);
		}

		if (PCIE(sih))
		if (sii->icbus->hosttype == BCMA_HOSTTYPE_PCI)
		bcma_core_pci_extend_L1timer(&sii->icbus->drv_pci, true);
		}

		@@ -792,7 +791,7 @@ void ai_pci_down(struct si_pub *sih)
		bcma_core_set_clockmode(cc, BCMA_CLKMODE_DYNAMIC);
		}

		if (PCIE(sih))
		if (sii->icbus->hosttype == BCMA_HOSTTYPE_PCI)
		bcma_core_pci_extend_L1timer(&sii->icbus->drv_pci, false);
		}