Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5570fe5 authored by Chris Wilson's avatar Chris Wilson
Browse files

Revert "drm/i915/dp: Ratelimit DP aux timeout messages" 



This reverts commit 7ee68603 "drm/i915/dp: Ratelimit DP aux timeout
messages" as although it successfully squelches the debug messages, when
it does so it generates a warning instead. CI lights up orange with all
the warnings!

In its current incarnation DRM_DEBUG_RATELIMITED is not usable for us,
and we need to first teach lib/ratelimit.c not to warn when used for
debug messages.

Fixes: 7ee68603 ("drm/i915/dp: Ratelimit DP aux timeout messages")
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Lyude <lyude@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Link: http://patchwork.freedesktop.org/patch/msgid/20170223115102.7059-1-chris@chris-wilson.co.uk


Acked-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
parent 08f5ba97

drivers/gpu/drm/i915/intel_dp.c

+1 −2
Original line number Diff line number Diff line
@@ -1121,8 +1121,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, 
	/* Timeouts occur when the device isn't connected, so they're

	 * "normal" -- don't fill the kernel log with these */

	if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {

		DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch timeout status 0x%08x\n",

					  status);

		DRM_DEBUG_KMS("dp_aux_ch timeout status 0x%08x\n", status);

		ret = -ETIMEDOUT;

		goto out;

	}