Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4f0927e authored by Roger Quadros's avatar Roger Quadros Committed by Felipe Balbi
Browse files

usb: gadget: core: Fix ->udc_set_speed() speed handling 



Currently UDC core calls ->udc_set_speed() with the speed parameter
containing the maximum speed supported by the gadget function
driver. This might very well be more than that supported by the
UDC controller driver.

Select the lesser of the 2 speeds so both UDC and gadget function
driver are operating within limits.

This fixes PHY Erratic errors and 2 second enumeration delay on
TI's AM437x platforms.

Fixes: 6099eca796ae ("usb: gadget: core: introduce ->udc_set_speed() method")
Cc: <stable@vger.kernel.org> # v4.13+
Reported-by: default avatarDylan Howey <Dylan.Howey@tennantco.com>
Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 7a9618a2

drivers/usb/gadget/udc/core.c

+6 −2
Original line number Diff line number Diff line
@@ -1069,8 +1069,12 @@ static inline void usb_gadget_udc_stop(struct usb_udc *udc) 
static inline void usb_gadget_udc_set_speed(struct usb_udc *udc,

					    enum usb_device_speed speed)

{

	if (udc->gadget->ops->udc_set_speed)

		udc->gadget->ops->udc_set_speed(udc->gadget, speed);

	if (udc->gadget->ops->udc_set_speed) {

		enum usb_device_speed s;



		s = min(speed, udc->gadget->max_speed);

		udc->gadget->ops->udc_set_speed(udc->gadget, s);

	}

}



/**