Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4ed61e3 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Greg Kroah-Hartman
Browse files

ixgbe: ensure IPsec VF<->PF compatibility 



[ Upstream commit f049efc7f7cd2f3c419f55040928eaefb13b3636 ]

The VF driver can forward any IPsec flags and such makes the function
is not extendable and prone to backward/forward incompatibility.

If new software runs on VF, it won't know that PF configured something
completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag.

Fixes: eda0333a ("ixgbe: add VF IPsec management")
Reviewed-by: default avatarRaed Salem <raeds@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Reviewed-by: default avatarShannon Nelson <snelson@pensando.io>
Tested-by: default avatarKonrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Link: https://lore.kernel.org/r/20220427173152.443102-1-anthony.l.nguyen@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 406aaef0

drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c

+2 −1
Original line number Diff line number Diff line
@@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf) 
	/* Tx IPsec offload doesn't seem to work on this

	 * device, so block these requests for now.

	 */

	if (!(sam->flags & XFRM_OFFLOAD_INBOUND)) {

	sam->flags = sam->flags & ~XFRM_OFFLOAD_IPV6;

	if (sam->flags != XFRM_OFFLOAD_INBOUND) {

		err = -EOPNOTSUPP;

		goto err_out;

	}