Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4ec92ed authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (ina3221) Use permission specific SENSOR[_DEVICE]_ATTR variants 

Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.

Also replace any remaining S_<PERMS> in the driver with octal values.

The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/

.

This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 46dce7a1

drivers/hwmon/ina3221.c

+7 −10
Original line number Diff line number Diff line
@@ -499,7 +499,7 @@ static const struct hwmon_chip_info ina3221_chip_info = { 
};



/* Extra attribute groups */

static ssize_t ina3221_show_shunt(struct device *dev,

static ssize_t ina3221_shunt_show(struct device *dev,

				  struct device_attribute *attr, char *buf)

{

	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr);
@@ -510,7 +510,7 @@ static ssize_t ina3221_show_shunt(struct device *dev, 
	return snprintf(buf, PAGE_SIZE, "%d\n", input->shunt_resistor);

}



static ssize_t ina3221_set_shunt(struct device *dev,

static ssize_t ina3221_shunt_store(struct device *dev,

				   struct device_attribute *attr,

				   const char *buf, size_t count)

{
@@ -533,12 +533,9 @@ static ssize_t ina3221_set_shunt(struct device *dev, 
}



/* shunt resistance */

static SENSOR_DEVICE_ATTR(shunt1_resistor, S_IRUGO | S_IWUSR,

		ina3221_show_shunt, ina3221_set_shunt, INA3221_CHANNEL1);

static SENSOR_DEVICE_ATTR(shunt2_resistor, S_IRUGO | S_IWUSR,

		ina3221_show_shunt, ina3221_set_shunt, INA3221_CHANNEL2);

static SENSOR_DEVICE_ATTR(shunt3_resistor, S_IRUGO | S_IWUSR,

		ina3221_show_shunt, ina3221_set_shunt, INA3221_CHANNEL3);

static SENSOR_DEVICE_ATTR_RW(shunt1_resistor, ina3221_shunt, INA3221_CHANNEL1);

static SENSOR_DEVICE_ATTR_RW(shunt2_resistor, ina3221_shunt, INA3221_CHANNEL2);

static SENSOR_DEVICE_ATTR_RW(shunt3_resistor, ina3221_shunt, INA3221_CHANNEL3);



static struct attribute *ina3221_attrs[] = {

	&sensor_dev_attr_shunt1_resistor.dev_attr.attr,