Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4870f79 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by David S. Miller
Browse files

vxlan: Wrong type passed to %pIS 



src_ip is a pointer to a union vxlan_addr, one member of which is a
struct sockaddr. Passing a pointer to src_ip is wrong; one should pass
the value of src_ip itself. Since %pIS formally expects something of
type struct sockaddr*, let's pass a pointer to the appropriate union
member, though this of course doesn't change the generated code.

Fixes: e4c7ed41 ("vxlan: add ipv6 support")
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fd972b73

drivers/net/vxlan.c

+1 −1
Original line number Diff line number Diff line
@@ -991,7 +991,7 @@ static bool vxlan_snoop(struct net_device *dev, 
		if (net_ratelimit())

			netdev_info(dev,

				    "%pM migrated from %pIS to %pIS\n",

				    src_mac, &rdst->remote_ip, &src_ip);

				    src_mac, &rdst->remote_ip.sa, &src_ip->sa);



		rdst->remote_ip = *src_ip;

		f->updated = jiffies;